fix creating a CacheKernel in HTTP cache documentation #9222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danrot thanks for fixing this! Your changes are perfectly fine, because even in this very same article we show the |
javiereguiluz
added a commit
that referenced
this pull request
Feb 8, 2018
…anrot) This PR was submitted for the master branch but it was merged into the 4.0 branch instead (closes #9222). Discussion ---------- fix creating a CacheKernel in HTTP cache documentation Hey, I was trying out to use the HTTP Cache for a talk and lecture I am giving, and with the instructions in the HTTP Cache documentation I only got an error that the class was not found. The changes I introduced here were also necessary. However, I am not completely sure if I missed something else, since I just skimmed the documentation, but I thought I send a PR anyway so that you see what I am talking about 😃 Commits ------- cc09426 fix creating a CacheKernel in HTTP cache documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I was trying out to use the HTTP Cache for a talk and lecture I am giving, and with the instructions in the HTTP Cache documentation I only got an error that the class was not found. The changes I introduced here were also necessary. However, I am not completely sure if I missed something else, since I just skimmed the documentation, but I thought I send a PR anyway so that you see what I am talking about 😃